-
Notifications
You must be signed in to change notification settings - Fork 0
[Imported] Ko: Translated into Korean. #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Imported comment from @Hikai @donnemartin How many reviewers do need? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Imported comment from @roeniss @Hikai According to contirubtion guide and translation guide, it seems that you need to get reviews by Korean Translation maintainers. Hi, @bonomoon and @mingrammer. Can you review this full translation, please? |
Imported comment from @OsoriAndOmori It looks good to me. thanks 👍 |
Imported comment from @roeniss Hi @donnemartin, are you in charge of the merge? I think it's ready. |
Imported comment from @bossm0n5t3r Please merge this PR. I really really want to read this. @donnemartin |
Imported comment from @Hikai 2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out. However, due to the lack of time due to the main job, the estimated time required is unknown. I would appreciate it if other Koreans who participate in the PR. :) |
Imported comment from @eomiso
@Hikai Why is this PR still open? Do you need a hand in getting this PR merged? |
Imported comment from @Hikai
@eomiso |
Imported review by @andrewchoi5 State: APPROVED No content |
Imported review by @korkt-kim State: APPROVED No content |
Imported review by @mode9 State: APPROVED Awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally👏
@bossm0n5t3r thanks,
I started from the newest PR and I am about to close all the older PR including those and then start updated the repo, so maybe a better time for the old translations - will be later Anyway - if you want me to merge it - can you please resolve the conflicts and sync will the latest English version? |
@ido777 So, does that mean I should clone the repo, check out this branch, and then sync the contents of the main branch's README.md into this branch's README-ko.md file? |
Basically yes, but you can do it from the GitHub gui with no need for
clone.
But the way you suggest is most common
I cleaned old pr and I have many thoughts about how to make this repo
update one of the things I think that maybe with the improvements in llm
translation maybe we don’t need to add translation
Wdyt?
…On Fri, 11 Apr 2025 at 10:55 bossm0n5t3r ***@***.***> wrote:
@ido777 <https://github.com/ido777> So, does that mean I should clone the
repo, check out this branch, and then sync the contents of the main
branch's README.md into this branch's README-ko.md file?
—
Reply to this email directly, view it on GitHub
<#421 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSAFJLNNWWD556BC7OBT4T2Y5YO3AVCNFSM6AAAAAB2SCXXOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJWGEZTINJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*bossm0n5t3r* left a comment (ido777/system-design-primer-update#421)
<#421 (comment)>
@ido777 <https://github.com/ido777> So, does that mean I should clone the
repo, check out this branch, and then sync the contents of the main
branch's README.md into this branch's README-ko.md file?
—
Reply to this email directly, view it on GitHub
<#421 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSAFJLNNWWD556BC7OBT4T2Y5YO3AVCNFSM6AAAAAB2SCXXOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJWGEZTINJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I agree with this perspective. Those who truly need the information will proactively seek it out. However, considering the nature of open-source projects, translations often organically emerge through community contributions over time. |
Imported from donnemartin/system-design-primer#476
Original author: @Hikai
According to #102, Korean translation began in September 2017, but it was not completed for about three years until September 2020.
Newly translated and put a pull request. Please merge after the review.