Skip to content

[Imported] Ko: Translated into Korean. #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ido777
Copy link
Owner

@ido777 ido777 commented Apr 6, 2025

Imported from donnemartin/system-design-primer#476

Original author: @Hikai


According to #102, Korean translation began in September 2017, but it was not completed for about three years until September 2020.
Newly translated and put a pull request. Please merge after the review.

@Copilot Copilot AI review requested due to automatic review settings April 6, 2025 20:37
@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @Hikai

@donnemartin How many reviewers do need?

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @roeniss

@Hikai According to contirubtion guide and translation guide, it seems that you need to get reviews by Korean Translation maintainers.

Hi, @bonomoon and @mingrammer. Can you review this full translation, please?

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @OsoriAndOmori

It looks good to me. thanks 👍

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @bonomoon

@roeniss Sorry for my late reply. I have all reviewed. Thanks to @Hikai

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @roeniss

Hi @donnemartin, are you in charge of the merge? I think it's ready.

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @bossm0n5t3r

Please merge this PR. I really really want to read this. @donnemartin

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @Hikai

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.

However, due to the lack of time due to the main job, the estimated time required is unknown.

I would appreciate it if other Koreans who participate in the PR. :)

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @KKimj

@Hikai
Thanks!

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @eomiso

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.

However, due to the lack of time due to the main job, the estimated time required is unknown.

I would appreciate it if other Koreans who participate in the PR. :)

@Hikai Why is this PR still open? Do you need a hand in getting this PR merged?

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @Hikai

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.
However, due to the lack of time due to the main job, the estimated time required is unknown.
I would appreciate it if other Koreans who participate in the PR. :)

@Hikai Why is this PR still open? Do you need a hand in getting this PR merged?

@eomiso
I don't know what things I needs.
I want to merge this PR but maintainer seems busy. :(

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported review by @andrewchoi5

State: APPROVED

No content

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported review by @korkt-kim

State: APPROVED

No content

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported review by @mode9

State: APPROVED

Awesome

Copy link

@bossm0n5t3r bossm0n5t3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally👏

@ido777
Copy link
Owner Author

ido777 commented Apr 8, 2025

@bossm0n5t3r thanks,
Some points I want to make

  1. I am not the original author of the repo system-design-primer, I an just trying to revive it since it seems that there are no updates in the last years
    I just started with the PR and issues but I have many ideas about what can be improved - will be happy to get help

  2. I am not sure about "the right thing to do" with the translations at all for various open questions here are my thoughts

  • For the 8 years of the original repo existence not many translations were updated after each English version changes, it seems hard to keep up
  • Today there are real good API for translations
  • Anyway it seems the English is must in order to work in the High Tech industry
  • We might either skip the translations at all or try automatic translation to make sure it is sync with or without human feedback

I started from the newest PR and I am about to close all the older PR including those and then start updated the repo, so maybe a better time for the old translations - will be later

Anyway - if you want me to merge it - can you please resolve the conflicts and sync will the latest English version?

@ido777 ido777 mentioned this pull request Apr 8, 2025
@bossm0n5t3r
Copy link

@ido777 So, does that mean I should clone the repo, check out this branch, and then sync the contents of the main branch's README.md into this branch's README-ko.md file?

@ido777
Copy link
Owner Author

ido777 commented Apr 13, 2025 via email

@bossm0n5t3r
Copy link

I agree with this perspective. Those who truly need the information will proactively seek it out. However, considering the nature of open-source projects, translations often organically emerge through community contributions over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants