Updating event handlers to hooks

[visheshjoshi]

The handlers
on('activate') and on('deactivate') don't work. Updating them to route hooks instead.

[ursm]

Hi,

Which Ember version do you use? ember-mousetrap uses "Activate and Deactivate Events" that introduced in Ember 1.9.
http://emberjs.com/blog/2014/12/08/ember-1-9-0-released.html#toc_activate-and-deactivate-events
I think on() is more desirable than defining a method because it isn't necessary to call _super() explicitly.

[visheshjoshi]

I currently use 1.8.1 but am planning to upgrade soon. I think your point is pretty valid, but maybe a couple of things can be considered:

1. Calling hooks gives backward compatibility.
2. For libraries such as mousetrap, having multiple sources of observation (events) can be tricky to manage, and it might be a good idea to do bindings in hooks which gets called once in a render cycle.