Skip to content

Adding View mixin #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
visheshjoshi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding View mixin #6

visheshjoshi wants to merge 2 commits into from

Conversation

@visheshjoshi
Copy link

@visheshjoshi visheshjoshi commented May 1, 2015

As discussed in
#5

@visheshjoshi visheshjoshi mentioned this pull request May 1, 2015
Open
visheshjoshi
visheshjoshi reviewed May 1, 2015
View reviewed changes
addon/mixins/mousetrap-view.js
Copy link
Author

@visheshjoshi visheshjoshi May 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ember.run.bind

@ursm
Copy link
Member

ursm commented May 28, 2015

Looks good. Would you correct indent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@visheshjoshi @ursm