[ refactor ] ScopedSnocList: Swap Scope on SnocList (Phase 2)
#3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
GulinSS
force-pushed
the
scoped-snoc-list-swap
branch
from
2a9fa0b to
b68532b
Compare
GulinSS
force-pushed
the
scoped-snoc-list-swap
branch
4 times, most recently
from
bed6788 to
ff61ad5
Compare
Core idea is to split the process of transition from List-based Context on SnocList-based Context on 2 phases: 1. Apply a refactor which does not make any transition (even no observable changes for Idris users) actually but prepare the code for future update. 2. Roll out the transition with limited code changes invasion because it was partially done at the step before. Co-authored-by: Viktor Yudov <[email protected]>
Co-authored-by: Viktor Yudov <[email protected]>
* [ refactor ] Replace `rev` with `reverse` and make `LengthMatch` arguments erased * [ refactor ] Move `embed'` definition into `FreelyEmbeddable` implementation * [ refactor ] Optimize `mkPatClause.mkNames` in `CaseBuilder` * [ refactor ] Swap parameters of `NamedPats` * [ refactor ] Remove `snoc` for `NamedPats` * [ refactor ] Use `List` for forward order in `CaseBuilder.idr` * [ refactor ] Swap the arguments of `PatClause`, `Group` and `ScoredPats` like `NamedPats` * [ refactor ] Merge simillar cases in `nextNames'` and `mkNames` * [ cleanup ] Remove redudant functions Cherry-picked from #16 Fully authored by Viktor Yudov <[email protected]> Co-authored-by: Viktor Yudov <[email protected]>
GulinSS
force-pushed
the
scoped-snoc-list-swap
branch
from
ff61ad5 to
9367788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be considered to merge ONLY AFTER applying #3512 and actual rebasing.
It is a DEMO place for discussion about coming changes at full amount of changes.
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).