Skip to content

[ fix ] Remove type constructor tags #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spcfox
Copy link
Contributor

@spcfox spcfox commented Jun 10, 2025

Description

Currently, the type constructor tag is always 100. In fact, they are not used. Therefore, I propose to remove them and also fix several related bugs.

Commits:

  1. Fixed a bug that prevented the tag counter from increasing
  2. Fixed irrefutable pattern with type in index
  3. Fixed checking for emptiness of type with type in index. This is the only place where type constructors are compared by tags. But they are unique only within the module. Therefore, type constructors should be compared by name, as in all other places.
  4. Type constructor tags have been removed because they are not suitable for comparison and are no longer used.
  5. Remove some boilerplate.

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

@spcfox
Copy link
Contributor Author

spcfox commented Jun 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant