[ ci ] Update ci-bootstrap.yml#3729
Open
spcfox wants to merge 2 commits intoidris-lang:mainfrom
Open
Conversation
Contributor
Author
|
The current actionlint version lacks support for the new runner. I intend to raise a PR to update our linters within the coming days |
2 tasks
| name: Bootstrap | ||
|
|
||
| env: | ||
| MIN_CHEZ_VERSION: 9.5.1 |
Contributor
There was a problem hiding this comment.
where did you get this number?
| sudo apt-get update | ||
| sudo apt-get install -y chezscheme | ||
| echo "$HOME/.idris2/bin" >> "$GITHUB_PATH" | ||
| sudo apt-get install -y uuid-dev |
Contributor
There was a problem hiding this comment.
what's this for? I can't see any mention of it in the chez build docs https://github.com/cisco/ChezScheme/blob/main/BUILDING
| - A Scheme compiler. One of | ||
| - Chez Scheme (default).\ | ||
| Version `9.5.1` or newer; on Apple Silicon `10.0.0` or newer. | ||
| - Racket. |
Contributor
There was a problem hiding this comment.
is there any benefit to building the bootstrap build on racket too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ci-bootstrap currently runs on the deprecated
ubuntu-20.04runner, which was retired some time ago.The original purpose of this job was to ensure we could build with older Chez Scheme versions from before support for
__collect_safe. That check is no longer relevant:__collect_safelanded in Chez Scheme 9.5.1, and the same release introducedcollect-rendezvous(Chez release notes, 2.81 and 2.82), which Idris 2 now relies on.Idris2/src/Compiler/Scheme/Chez.idr
Line 109 in b714fca
This PR updates the workflow to run on a supported runner and repurposes it to test bootstrapping against the minimum supported Chez Scheme version.