[ refactor ] Port Yaffle's Value#3754
Draft
GulinSS wants to merge 25 commits intoidris-lang:mainfrom
Draft
Conversation
Co-authored-by: Justus Matthiesen <mail@justusmatthiesen.com>
Replace List-based tracking of erased variables with specialized VarSet type for improved performance. Changes include: - Update getErased function in Env.idr to return VarSet instead of List - Modify linear check functions to use VarSet operations throughout - Add elemNat helper for efficient natural number lookups in VarSet - Use VarSet.empty constant instead of empty lists - Apply proper weakening operations with varSetWeaken interface This improves efficiency of linearity checking by using specialized set operations instead of list traversals.
+ Cherry-picked refactor from #16 Co-authored-by: Viktor Yudov <me@spcfox.com> fix
- generalised lookup - define resolveRef as the weakening of findBound, add missing cases to substName - define underBinders, fix argument order - added underBinderz, more GenWeakenable instances - complete refactors regarding swapping inner/outer - change constructor argument representation from Scope to List Name Co-authored-by: Justus Matthiesen <mail@justusmatthiesen.com>
GulinSS
force-pushed
the
core-evaluate-value/all
branch
from
3577754 to
fe23002
Compare
GulinSS
force-pushed
the
core-evaluate-value/all
branch
from
fe23002 to
67977e6
Compare
Contributor
Author
|
Well, it was hard to rebase but still need some care to clean up comments, logs and so on. It was hard... no much to say for now. 😅 |
GulinSS
force-pushed
the
core-evaluate-value/all
branch
2 times, most recently
from
4faa6f3 to
64cd3ae
Compare
Co-authored-by: Viktor Yudov <me@spcfox.com> Co-authored-by: Denis Buzdalov <public@buzden.ru>
GulinSS
force-pushed
the
core-evaluate-value/all
branch
from
64cd3ae to
a2720d0
Compare
Co-authored-by: Viktor Yudov <me@spcfox.com>
GulinSS
force-pushed
the
core-evaluate-value/all
branch
from
6632c4a to
e747679
Compare
Co-authored-by: Viktor Yudov <me@spcfox.com>
Co-authored-by: Viktor Yudov <me@spcfox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks the ongoing effort to port Yaffle into the Idris2 codebase.
Work in progress — This PR is primarily for tracking progress. The current state is
outdated andincomplete.This PR requires the following to be merged first: #3513
PR commits will be squashed into a series of less number of commits to improve maintainability during rebases and ease review.
Squashed, origin: https://github.com/GulinSS/Idris2/tree/core-evaluate-value/all-no-compact