use withAll when evaluating %foreign strings#3801
Open
ear7h wants to merge 1 commit into
Open
Conversation
ear7h
force-pushed
the
issue-3790-fix-foreign-string
branch
from
June 17, 2026 15:04
ec5dd82 to
d146260
Compare
closes idris-lang#3790 Also adds some more details to the error messages when the expression evaluates to smething unexpected.
ear7h
force-pushed
the
issue-3790-fix-foreign-string
branch
from
June 17, 2026 15:05
d146260 to
849111c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The compiler was getting stuck when normalizing
%foreignand%foreign_implresulting inError: %foreign calling convention must evaluate to a String. This was caused bygetFnStringusingnfinstead ofnfOpts withAllwhich evaluates private names. This change reflects (heh) what's implemented inrunElab:Idris2/src/TTImp/ProcessRunElab.idr
Line 38 in 6ca00e7
Idris2/src/TTImp/Elab/RunElab.idr
Line 101 in 6ca00e7
Self-check
CONTRIBUTING.mdand I've updated
CONTRIBUTORSwith my name.implementation, I have updated
CHANGELOG_NEXT.md