fix: handle null user properly in forget password function #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the forgetPassword.js function where the code attempted to access user._id even when user was null. The fix adds a proper null check before accessing user._id.
Related Issues
Closes #1222
Steps to Test
Try resetting the password with an unregistered email.
Ensure the correct error message is returned: "No account with this email has been registered."
Try resetting the password with a valid email to confirm existing functionality remains unchanged.
Screenshots (if applicable)
Before
After
Checklist
y I have tested these changes
y I have updated the relevant documentation
y I have commented my code, particularly in hard-to-understand areas
y I have made corresponding changes to the codebase
y My changes generate no new warnings or errors
The title of my pull request is clear and descriptive