fix: Multiple Search API Triggered (closes #1413)#1416
Open
rpsinghcodes wants to merge 1 commit intoidurar:masterfrom
Open
fix: Multiple Search API Triggered (closes #1413)#1416rpsinghcodes wants to merge 1 commit intoidurar:masterfrom
rpsinghcodes wants to merge 1 commit intoidurar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue where the search API was being triggered multiple times on initial page load, even when no data was available.
The root cause was the use of dynamically generated keys (
shortid()) for components rendered insidePageHeader. Since a new key was generated on every render, React treated these components as new instances, causing them to unmount and remount repeatedly, which re-triggered side effects and search API calls.The fix removes the use of dynamically generated keys and relies on stable component rendering to prevent unnecessary re-renders and API calls.
Related Issues
Steps to Test
DataTablecomponent (e.g. Quotes, Invoices, Payments).Screenshots (if applicable)
N/A – no visual UI changes.
Checklist