Skip to content

fix: reject MongoDB operator injection in query filter params #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theeggorchicken wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: reject MongoDB operator injection in query filter params #1423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions backend/src/controllers/middlewaresControllers/createCRUDController/paginatedList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,23 @@ const paginatedList = async (Model, req, res) => {
fields.$or.push({ [field]: { $regex: new RegExp(req.query.q, 'i') } });
}

// Build filter condition safely: reject MongoDB operators in values
let filterCondition = {};
if (filter && equal !== undefined) {
if (typeof equal === 'object') {
return res.status(400).json({
success: false,
result: [],
message: 'Invalid filter value',
});
}
filterCondition = { [filter]: equal };
}

// Query the database for a list of all results
const resultsPromise = Model.find({
removed: false,

[filter]: equal,
...filterCondition,
...fields,
})
.skip(skip)
Expand All @@ -31,8 +43,7 @@ const paginatedList = async (Model, req, res) => {
// Counting the total documents
const countPromise = Model.countDocuments({
removed: false,

[filter]: equal,
...filterCondition,
...fields,
});
// Resolving both promises
Expand Down