-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add comprehensive e2e tests for Kimi AI functionality #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results25 tests +5 25 ✅ +5 4s ⏱️ -1s Results for commit 9e078d9. ± Comparison against base commit 41113d1. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This test creates a real Groq client which requires GROQ_API_KEY. Moving it to slow tests prevents CI failures while keeping the test available for manual execution with API credentials.
- Add test-ci: run GitHub Actions locally with act - Add test-ci-verbose: run with verbose output - Add test-ci-amd64: run with AMD64 architecture for M1/M2 Macs - Add list-workflows: show available GitHub Actions - Add test-github-sim: run shell script simulation alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Uses Hardcoded Path, Fails in CI
The test_kimi_commit_command_e2e in tests/e2e/test_kimi_e2e.py uses a hardcoded absolute path (/Users/idvorkin/gits/nlp) for the cwd parameter in a subprocess.run call. This makes the test non-portable, causing failures on other machines or in CI environments. It also defeats the purpose of the temporary git repository setup by running the command from an unrelated, hardcoded location.
tests/e2e/test_kimi_e2e.py#L98-L99
nlp/tests/e2e/test_kimi_e2e.py
Lines 98 to 99 in 9e078d9
| timeout=60, | |
| cwd="/Users/idvorkin/gits/nlp", |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Summary
just test-e2ecommand for running all e2e testsTest Coverage
thinkandcommitcommands with--kimiflag--kimi/--no-kimioptions appear in helpJustfile Commands
just test-e2e: Run all e2e tests (requires GROQ_API_KEY for full coverage)Test Plan
🤖 Generated with Claude Code