Skip to content

Conversation

@idvorkin
Copy link
Owner

Summary

  • Create tests/e2e directory structure for end-to-end testing
  • Add comprehensive CLI command tests for Kimi AI functionality
  • Test actual think and commit commands with Kimi via subprocess
  • Verify Kimi model registration and LangChain integration
  • Add generic just test-e2e command for running all e2e tests

Test Coverage

  • CLI Integration: Tests actual think and commit commands with --kimi flag
  • Model Selection: Verifies Kimi is properly selected when multiple models available
  • Default Behavior: Tests that Kimi is enabled by default as specified
  • Help Output: Verifies --kimi/--no-kimi options appear in help
  • Model Registration: Fast tests for ELL and LangChain integration
  • API Integration: Real API calls to verify functionality (requires GROQ_API_KEY)

Justfile Commands

  • just test-e2e: Run all e2e tests (requires GROQ_API_KEY for full coverage)

Test Plan

  • Fast unit tests for model registration pass without API keys
  • Help output tests verify CLI options are present
  • E2E tests structured to skip gracefully without GROQ_API_KEY
  • All tests follow existing project patterns and conventions

🤖 Generated with Claude Code

@github-actions
Copy link

github-actions bot commented Jul 20, 2025

Test Results

25 tests  +5   25 ✅ +5   4s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9e078d9. ± Comparison against base commit 41113d1.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
tests.test_langchain_helper ‑ test_get_model_name_integration_with_real_models
tests.e2e.test_kimi_e2e ‑ test_kimi_model_registration
tests.test_ell_helper ‑ test_get_ell_model_default_priority
tests.test_ell_helper ‑ test_get_ell_model_exclusive_selection
tests.test_ell_helper ‑ test_get_ell_model_kimi
tests.test_ell_helper ‑ test_get_ell_model_kimi_defaults_false
tests.test_ell_helper ‑ test_get_ell_model_kimi_vs_other_models

♻️ This comment has been updated with latest results.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

This test creates a real Groq client which requires GROQ_API_KEY.
Moving it to slow tests prevents CI failures while keeping the test
available for manual execution with API credentials.
cursor[bot]

This comment was marked as outdated.

- Add test-ci: run GitHub Actions locally with act
- Add test-ci-verbose: run with verbose output
- Add test-ci-amd64: run with AMD64 architecture for M1/M2 Macs
- Add list-workflows: show available GitHub Actions
- Add test-github-sim: run shell script simulation alternative
cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Uses Hardcoded Path, Fails in CI

The test_kimi_commit_command_e2e in tests/e2e/test_kimi_e2e.py uses a hardcoded absolute path (/Users/idvorkin/gits/nlp) for the cwd parameter in a subprocess.run call. This makes the test non-portable, causing failures on other machines or in CI environments. It also defeats the purpose of the temporary git repository setup by running the command from an unrelated, hardcoded location.

tests/e2e/test_kimi_e2e.py#L98-L99

timeout=60,
cwd="/Users/idvorkin/gits/nlp",

justfile#L98-L99

https://github.com/idvorkin/nlp/blob/9e078d9cb9e939bc7de062db7bdad880eb314a9b/justfile#L98-L99

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants