wordsmith definition of landmark and landmark subtree - #268
Merged
Conversation
Rationale: the previous definition said landmark subtrees were determined by a single landmark, which is imprecise. They're determined by the interval between two. Also, it's clarifying to know up front that there are commonly two subtrees per interval, not one as someone might guess. Also rework the definition of landmark slightly to emphasize that they are meaningful primarily as members of a sequence. This may clear up some confusion I had when first reading the spec, and have heard from others, about whether a landmark _is_ a subtree.
davidben
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: the previous definition said landmark subtrees were determined by a single landmark, which is imprecise. They're determined by the interval between two. Also, it's clarifying to know up front that there are commonly two subtrees per interval, not one as someone might guess.
Also rework the definition of landmark slightly to emphasize that they are meaningful primarily as members of a sequence.
This may clear up some confusion I had when first reading the spec, and have heard from others, about whether a landmark is a subtree.