-
Notifications
You must be signed in to change notification settings - Fork 4
Fix: #110. Interoperability considerations instead of new parameter #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -309,6 +334,9 @@ Q: Why this document? | |||
This has some security implications too | |||
(eg. wrt on identifying parsers or treat downloads) | |||
|
|||
Q: Do we support OpenAPI 2.0 / Swagger? | |||
: No, this document is about OpenAPI 3.0 and above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other PR. Why would we limit this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let bygones be bygones :)
I think that OAS 3.0 is the first specification with a standardization base,
and referencing 2.0 does not help interoperability.
Moreover, it's in an FAQ that will be removed at publication.
What does this mean, exactly? OAS 2.0 (which was a tiny bit different from Swagger 2.0, but mostly just small fixes to errors) was the first version released under the OpenAPI Initiative. So it's as standardized as 3.0 or 3.1.
Didn't we define a
Does this mean that in practice, 2.0 is not excluded? I'm a bit confused. |
This makes sense, but I think that migration should be the only reason for that. Actually, using
Anyway, I'm not that into v2.0, but if you/ @darrelmiller think that this document suits OAS 2.0, we can extend the scope. |
9c04640
to
76c3820
Compare
A server can publish an OpenAPI resource that | ||
does not contain an "OpenAPI Object". | ||
In this case, the `version` parameter is useful to identify | ||
the specification version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is talking about using the version
parameter in the Content-Type
header of a response, or a similar usage, correct? Should this be made more clear when initially discussing the parameter usage? What happens when a version
paramter is used in this way with an OpenAPI Document (with an OpenAPI Object) where the openapi
field disagrees with the version
parameter? "Disagrees" here needs to be handled with the same concerns over compatibility and version matching that I just brought up in #124.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the version parameter in the Content-Type header of a response
Yes, this is stated in the document introduction: can you please check if it's clear enough here?
What happens when a version paramter disagrees with the version [specified in the OpenAPI object]
I think prescribing a behavior may go beyond the scope of the media type registration,
since:
- it is responsibility of the sender to ensure the correct value of the media type;
- it is a choice of the client to decide the tolerance threshold according to its use case.
Maybe the above wording could fit the Interoperability considerations.
Agree to discuss this further in #124.
This PR