ci(msstore): remove obsolete upload-timeout workaround - #107
Merged
Conversation
This reverts PR ififi2017#68. The explicit --uploadTimeout was a workaround for microsoft/msstore-cli#162, where an omitted --uploadTimeout resolved to 0 and cancelled every Azure blob request immediately. That bug is fixed by microsoft/msstore-cli#163 and shipped in msstore-cli v0.4.2 (2026-09-02). The action installs 'latest', so the workaround is no longer needed and the documented 100s default applies again. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a33ffb27-8072-43c0-beb7-a7bc7e8e2229
|
@azchohfi is attempting to deploy a commit to the ififi2017's projects Team on Vercel. A member of the Team first needs to authorize it. |
ififi2017
changed the title
Owner
|
Thanks for fixing this upstream and following through here — really appreciate it! The revert looks good. We’ll handle pinning the CLI version on our side. |
Contributor
Author
|
Happy to help, and sorry for breaking you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/msstore-cli#162 is fixed and released, so the workaround added in #68 can come out.
Background
--uploadTimeoutwas added in msstore-cli v0.4.0 with aCustomParserbut noDefaultValueFactory. System.CommandLine only runs aCustomParserwhen the option is actually present on the command line, so omitting it left the value atdefault(long)—0— which became the Azure blob client'sRetry.NetworkTimeout. Every request was cancelled the instant it started.Why it is safe to revert now
microsoft/microsoft-store-apppublisher@v1.1, whoseversioninput defaults tolatest— so the runner now gets v0.4.2 and the documented 100 s default applies.StorageTransferOptions, so a package under 256 MiB uploads as a single PUT and the timeout covers the whole transfer rather than one chunk. That only matters for much larger packages.)Note
Because the action tracks
latest, a future CLI regression could reach this workflow again with no pin to stop it. Pinningversion:is worth considering separately.Sent as part of a sweep across the repos that referenced msstore-cli#162.