Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tests, fix headers.double type, ehance typing #22

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: add tests, fix headers.double type, ehance typing #22

merged 1 commit into from
Dec 16, 2024

Conversation

T1B0
Copy link
Collaborator

@T1B0 T1B0 commented Dec 15, 2024

  • add unit test
  • fix Header.double binary encoding
  • better typing & errors around messages

@T1B0 T1B0 requested review from spetz and Tchoupinax December 15, 2024 08:40
Tchoupinax
Tchoupinax approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@Tchoupinax Tchoupinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/wire/number.utils.ts Show resolved Hide resolved
@T1B0 T1B0 merged commit 431063f into main Dec 16, 2024
2 checks passed
@T1B0 T1B0 deleted the add-test-fix-headers-double branch December 16, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tchoupinax Tchoupinax Tchoupinax approved these changes

@spetz spetz Awaiting requested review from spetz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T1B0 @Tchoupinax