Transfer batch accumulator when rolling to new segment #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numinnex
force-pushed
the
fix_accumulator_for_new_segment
branch
from
bfd592e to
a65f98d
Compare
numinnex
force-pushed
the
fix_accumulator_for_new_segment
branch
from
a65f98d to
b5d6821
Compare
numinnex
force-pushed
the
fix_accumulator_for_new_segment
branch
from
7f921b4 to
83d4346
Compare
numinnex
commented
Dec 3, 2024
| Buf: IoBuf, | ||
| S: Storage<Buf>, | ||
| { | ||
| storage: S, |
There was a problem hiding this comment.
add a block cache here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.