OF-3107 RPM spec cleanup #2949
Open
OF-3107 RPM spec cleanup #2949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Ponomarev <[email protected]>
… and make it static There is no practical need to change the PID file path Signed-off-by: Sergey Ponomarev <[email protected]>
stokito
commented
Jul 14, 2025
| BuildRoot: %{_builddir}/%{name}-root | ||
| Source0: %{OPENFIRE_SOURCE} | ||
| %ifarch noarch | ||
| # Note that epoch is set here to 1, this appears to be consistent with non-Redhat |
There was a problem hiding this comment.
epoch is set here to 1
Could you explain what does the comment mean? It looks like very outdated.
There was a problem hiding this comment.
I don't recall if we once had to mess with the RPM epoch due to some release issue or not. I also am unsure if it is needed anymore or not, but I thought once you bumped the epoch, you can't go back? shrug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.