CI: also run on Windows and MacOS #2986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
CI-include-Windows
branch
2 times, most recently
from
18be7b3 to
1611ca2
Compare
guusdk
added
backport 5.0
guusdk
force-pushed
the
CI-include-Windows
branch
3 times, most recently
from
3bab55e to
594df80
Compare
|
I have added this as a way to detect issues as reported in and fixed by #2982 However, running the build on Windows and MacOS does not reproduce these issues (they can be reproduced by including a space character in the working directory - I've attempted to do that, but there doesn't seem to be an easy/maintainable way to do that in GitHub workflows - at least none that I can find). With that, do we want to include Windows and MacOS as CI runners? They aren't exposing the issue that I had hoped, after all. With more runners, the chance of build failures because of flapping tests increases. |
guusdk
force-pushed
the
CI-include-Windows
branch
from
d4b7b88 to
594df80
Compare
As we're producing binaries for Windows, and that OS notably differs from Linux in things like the representation of a path on the file system, we should run CI in a Windows environment in addition to running it on Linux-based environments. While we're at it, we might as well also include MacOS.
akrherz
force-pushed
the
CI-include-Windows
branch
from
594df80 to
9c2c1b9
Compare
|
MacOS failure filed as https://igniterealtime.atlassian.net/browse/OF-3119 |
guusdk
added
backport 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're producing binaries for Windows, and that OS notably differs from Linux in things like the representation of a path on the file system, we should run CI in a Windows environment in addition to running it on Linux-based environments.
While we're at it, we might as well also include MacOS.