ChatMarkersManager improved - part 2 #272
Conversation
miguelhincapie
commented
Oct 4, 2018
miguelhincapie
commented
- Filters modified to allow xep-0333 be used in MUC.
- Validation when trying to obtain Chat instance.
- Created a method to notify the recipients about new state.
* Filters modified to allow xep-0333 be used in MUC. * Validation when trying to obtain Chat instance. * Created a method to notify the recipients about new state.
vanitasvitae
left a comment
vanitasvitae
left a comment
There was a problem hiding this comment.
Thank you again for your contributions 👍
I found some things that can be improved :)
smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersManager.java
Outdated
Show resolved
Hide resolved
|
This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there: https://discourse.igniterealtime.org/t/chat-markers-support-in-smack-xep-0333/73202/16 |
Flowdalic
left a comment
Flowdalic
left a comment
There was a problem hiding this comment.
Now that the big merge happened, I have some time to work on the pending PRs, starting with yours. :)
Please find my comments inline.
smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersManager.java
Outdated
Show resolved
Hide resolved
| * @throws InterruptedException if the connection is interrupted. | ||
| * @throws IllegalStateException if one of the params don't match the rules. | ||
| */ | ||
| public void markMessage(Message message, ChatMarkersState chatMarkersState, String messageId) |
There was a problem hiding this comment.
I would expect that the user gives as a message with a markable extension to such a method. Then you could remove the ChatMarkersState and String (messageId) parameters, which would make the method much more user friendly.
There was a problem hiding this comment.
but the user would need to deal with message.addExtension(new ChatMarkersElements.ReceivedExtension(messageId)); by himself, in other words he would doing some of the job that this class has to do.
What I want is class that can be used almost out of the box but of course knowing how the XEP works.
4 participants
