XEP-0084: User Avatars #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
commented
Jul 31, 2019
Member
Author
vanitasvitae
left a comment
vanitasvitae
left a comment
There was a problem hiding this comment.
There are some things that I do not fully understand about the code so far.
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/UserAvatarManager.java
Outdated
Show resolved
Hide resolved
Flowdalic
requested changes
Aug 22, 2019
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/MetadataInfo.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/MetadataInfo.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/MetadataInfo.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/MetadataInfo.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/element/MetadataExtension.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/element/MetadataExtension.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/element/DataExtension.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/provider/MetadataProvider.java
Outdated
Show resolved
Hide resolved
smack-extensions/src/main/java/org/jivesoftware/smackx/avatar/provider/MetadataProvider.java
Outdated
Show resolved
Hide resolved
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
f51edff to
3c31f0c
Compare
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
9f2a5c8 to
e5e5780
Compare
|
Any updates? |
Member
Author
|
I haven't had time to further work on this yet. You are truly welcome to contribute though if you have the resources ;) |
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
e5e5780 to
cef58fd
Compare
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
f3feb02 to
571a11e
Compare
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
571a11e to
992a3e9
Compare
vanitasvitae
added
Needs feedback
Needs squashing
and removed
Needs conflict resolution
labels
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
fd27fad to
aa09316
Compare
Co-authored-by: Paul Schaub <[email protected]>
vanitasvitae
force-pushed
the
ramabit.avatar
branch
from
b954bd5 to
0f5297c
Compare
Flowdalic
requested changes
Feb 15, 2021
Member
Flowdalic
left a comment
Flowdalic
left a comment
There was a problem hiding this comment.
Let us try to get this over the finish line. I think this mostly needs work regarding the AvatarStore interface.
Also please squash and rebase on the current master. Feel free to add a Co-authored-by git pseudo header.
| availabilityMap.put(new Tuple<>(jid, itemId), Boolean.TRUE); | ||
| } | ||
|
|
||
| private static class Tuple<A, B> { |
Member
There was a problem hiding this comment.
This class should be deleted and o.j.smack.util.Pair should be used instead.
| * whether the client already has a local copy of a published avatar or if the user needs to be informed about the | ||
| * update in order to download the image. | ||
| */ | ||
| public interface AvatarMetadataStore { |
Member
There was a problem hiding this comment.
I am confused by this "store", which does not actually seem to store avatars, just their availability.
Why not make it a real store-interface, e.g.
interface AvatarMetadataStore {
Avatar getAvatar(EntityBareJid jid, String itemId);
putAvatar(EntityBareJid jid, String itemId, Avatar avatar);
where Avatar is a meta class that encapsulates the MIME type and the avatar bytes.
Flowdalic
added
Needs rebasing
|
@vanitasvitae: Have you progressed on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #107 on current master.