Skip to content

WIP: Add support for XEP-0390: Entity Capability 2.0 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adiaholic wants to merge 6 commits into
base: master
Choose a base branch
from
Open

WIP: Add support for XEP-0390: Entity Capability 2.0 #432

adiaholic wants to merge 6 commits into from

Conversation

@adiaholic
Copy link
Contributor

@adiaholic adiaholic commented Sep 10, 2020

No description provided.

@vanitasvitae
Copy link
Member

vanitasvitae commented Sep 10, 2020 •
edited
Loading

Nice! I see you are not yet fed up with Smack development 👍

I guess you are going in the right direction. I'd implement full ecaps2 first and then see how to unify ecaps2 and caps1 under a common API that ideally is not too different from caps1. Maybe you can "hide" ecaps2 and caps1 under the current caps1 API even, that would give you the benefits from ecaps2 while users can reuse the same API they are already used to.

vanitasvitae
vanitasvitae suggested changes Sep 26, 2020
View reviewed changes
@stokito
Copy link
Contributor

stokito commented Oct 6, 2025

Maybe you can "hide" ecaps2 and caps1 under the current caps1 API

There is an article on this from Blabber author:
https://babbler-xmpp.blogspot.com/2018/02/experimenting-with-entity-capabilities.html

See the Blabber sources
https://github.com/sco0ter/babbler/blob/a161d7e212c5abcdca31d95c21626d14d8a53a7c/xmpp-core/common/src/main/java/rocks/xmpp/extensions/caps/EntityCapabilitiesManager.java#L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanitasvitae vanitasvitae vanitasvitae requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adiaholic @vanitasvitae @stokito