Instant Stream Resumption implementation #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flowdalic
reviewed
Oct 8, 2016
| hash.append(hex); | ||
| } | ||
| digest = hash.toString(); | ||
| } catch (UnsupportedEncodingException e) { |
Member
There was a problem hiding this comment.
Never swallow Exceptions! Use a try/multi-catch and throw a unchecked exception, e.g. InvalidStateException in this case. In cases where the exception can be ignored, log it at least with a FINE/FINER/FINEST level.
Flowdalic
reviewed
Oct 11, 2016
| } catch (InvalidKeyException e) { | ||
| } catch (NoSuchAlgorithmException e) { | ||
| } catch (UnsupportedEncodingException | InvalidKeyException | NoSuchAlgorithmException e) { | ||
| throw new IllegalStateException("HMAC digest couldn't be done correctly."); |
Member
There was a problem hiding this comment.
Add the catched Exception to the ISE, so that it doesn't get lost:
throw new IllegalStateException("HMAC digest couldn't be done correctly.", e);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation: http://xmpp.org/extensions/inbox/isr.html
WARNING: This implementation wasn't tested against a server yet.
However, it has many unit tests checking nonzas parsers and validations.
I send this PR in order to receive feedback and refine it.
fyi @Flowdalic