SPARK-2376: Improve error message when failing to join a chatroom #934
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a reference to the room that was being joined, and adds a more descriptive cause of the failure.
stokito
approved these changes
Jan 6, 2026
| String error = errors.get( 0 ); | ||
| JOptionPane.showMessageDialog( SparkManager.getMainWindow(), error, Res.getString("message.error.unable.join.room"), JOptionPane.ERROR_MESSAGE ); | ||
| final String style = "width: 300px;"; | ||
| String body = "<html><body><p style='"+style+"'>"+ roomJID + ": " + Res.getString("message.error.unable.join.room") +"</p><p></p><p style='"+style+"'>" + error + "</p></body></html>"; |
Contributor
There was a problem hiding this comment.
The HTML is needed only to set a width to the message dialog. Maybe we can move it inside of the showMessageDialog()
Member
Author
There was a problem hiding this comment.
I'm also using it for the blank line between the paragraphs.
Member
Author
|
Ah, I merged this with the wrong JIRA issue in the commit message. It's SPARK-2376 (not SPARK-2476). |
guusdk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a reference to the room that was being joined, and adds a more descriptive cause of the failure.