SPARK-2380: messages: fetch from URL only images #940
Merged
+31
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… often used http://
stokito
commented
Jan 8, 2026
| (link.startsWith("xmpp:") && link.contains("?join")) || | ||
| link.startsWith("file:/")) && link.indexOf(".") > 1) { | ||
| link.startsWith("file:/")) | ||
| && link.indexOf(".") > 1) { |
Contributor
Author
There was a problem hiding this comment.
I moved the condition to a separate line. In fact it tries to ensure that the link is not local domain i.e. not like http://tplinkrouter/cgi-bin/exploit.cgi but at least something.com.
stokito
commented
Jan 8, 2026
| final ClassicHttpRequest request = ClassicRequestBuilder.get(url) | ||
| .setHeader("Content-Type", "image/*") | ||
| final ClassicHttpRequest request = ClassicRequestBuilder.get(uri) | ||
| .setHeader("Accept", "image/*") |
Contributor
Author
There was a problem hiding this comment.
The Content-Type is a response header, for a request we should set the Accept header to show which mime types we want.
guusdk
approved these changes
Jan 8, 2026
Member
guusdk
left a comment
guusdk
left a comment
There was a problem hiding this comment.
I am not sure if this is a full fix, but it's at least a move in the right direction. Lets merge, experiment, and possibly improve in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://igniterealtime.atlassian.net/browse/SPARK-2380
The URLConnection.getFileNameMap() returns the
sun.net.www.MimeTablethat has a map of file extension to a MIME type. So we can guess a content type by an extension.This covers most use cases.