SPARK-2382 Do not safe colors.properties that have a default value #943
+336
−532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Size default to 32
…avy HashSet for skipFiles
Remove useless comment from the properties file
…_propertyHashMap Rename map to colorSettings
…roperties if it doesn't exist Don't save it also if it was enriched with defaults.
…settings that are different from a default
…www., remove redundant comments
…erences == null) that is always true
…f it doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://igniterealtime.atlassian.net/browse/SPARK-2382
The colors.properties can be removed if it wasn't changed.
The spark.properties still is going to be created but now it's at least faster during the app startup. I'll make the properties with default value to be skippable on a separate PR.