Feature/prevent add duplicate field#16
Open
itmiku wants to merge 3 commits intoigniterealtime:mainfrom
Open
Conversation
Fishbowler
reviewed
Nov 30, 2025
Member
Fishbowler
left a comment
Fishbowler
left a comment
There was a problem hiding this comment.
I'm not sure I understand the duplicate files?
Author
Removed the duplicate files, not needed in the root indeed |
Member
|
You've also moved some files from the root into the src directory. Does that want reverting? |
Author
|
That was needed as the assembly file assumes the files to be in the src directory and not the root dir. 
Note ${project.build.sourceDirectory}/ corresponds to src/main/java here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mucext GUI shows an error when trying to add a mucext field with a variable name that's already defined