-
-
Notifications
You must be signed in to change notification settings - Fork 418
Make battle buttons translatable #7706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy found issue(s) with the introduced code (1/1)
Leftover from when we had the WAIT button
if original language is used.
It turned out that the Settings button is 1 pixel higher than the AUTO button.
Move status bar and battle settings to generateDefaultImages()
|
Hi @zenseii , can you please explain what is missing to be implemented in this pull request? Can we help to move forward with the changes or the idea? |
|
@ihhub. There are 2 things necessary for this implementation to be ready:
Help with the first step would be appreciated and should be made in a different PR. |
Relates to and final part of #6105
This has been implemented:
For the Cyrillic font it looks quite good even though the buttons are slightly wider than the originals which means we have 15 pixels less for text:
Meanwhile, for the Latin font it is obvious that we have to cram the letters closer together. I found the sweet spot to be 2 pixels closer in the x-direction.
This is what it looks like for the Latin font without cramming:
Implementing a feature to cram letters would need a new function for calculating text width because it needs to take into account that the letters are rendered on top of each other, and we need a new function for actually rendering the text with letters on top of each other.
This change would give us 12 pixels more in width in the case when we have two words of 4 letters (ex. AUTO + SKIP), ( 2 pixels * ( 2 words * ( 4 letters - 1 first letter ) ) ). We would then only lose 3 pixels for text.
Such big changes might be better to do in a separate PR.
This change could be used to solve button problems like those described here #7548
This is what the SKIP button would look like with 2 pixels closer for letters.

Related to #9261