Skip to content

Add Modin backends to dev requirements #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmbc wants to merge 2 commits into
base: epic/modin
Choose a base branch
from
Open

Add Modin backends to dev requirements #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74ee08
Add Modin backends to dev requirements
zmbc Jan 9, 2024
523bb03
Add Modin engines to test_requirements
zmbc Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,14 @@
"jupyter",
]

modin_requirements = ["modin"]

modin_test_engines_requirements = ["ray", "dask"]

test_requirements = [
"pytest",
"pytest-mock",
]
] + modin_test_engines_requirements
Copy link
Collaborator

@rmudambi rmudambi Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused. Is there a situation in which we would want to be able to install our test requirements but not the modin test requirements? If so, we aren't able to as you have it, but if we wouldn't, why not just include ray and dask in the test-requirements directly?

Copy link
Collaborator Author

@zmbc zmbc Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could include ray and dask in the test_requirements directly; the idea here was just to make it easier to see the different types of requirements. But if you think it adds confusion, I'll change it.

Copy link
Collaborator

@rmudambi rmudambi Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be bundled unless we want to enable a person to install only test without dask/ray and be able to run the tests that don't use them. That seems like an unlikely use case?


doc_requirements = [
"sphinx>=4.0",
Expand All @@ -63,8 +67,6 @@
"matplotlib",
]

modin_requirements = ["modin"]

setup(
name=about["__title__"],
description=about["__summary__"],
Expand Down