Fix dtype bug in int columns#405
Merged
zmbc merged 4 commits intorelease-candidate/dtypes-distributed-noisingfrom Apr 25, 2024
Merged
Fix dtype bug in int columns#405zmbc merged 4 commits intorelease-candidate/dtypes-distributed-noisingfrom
zmbc merged 4 commits intorelease-candidate/dtypes-distributed-noisingfrom
Conversation
zmbc
requested review from
albrja,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
1 task
albrja
approved these changes
Apr 24, 2024
rmudambi
approved these changes
Apr 25, 2024
Collaborator
|
This should also target a release branch. |
zmbc
changed the base branch from
main
to
release-candidate/dtypes-distributed-noising
…uted-noising' into bugfix/int-dtypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dtype bug in int columns
Description
Discovered in the course of working on #404 that there was some very strange dtype behavior going on: pseudopeople was returning columns with dtype "object" that contained integer objects. Our test was not catching this.
I've beefed up the test (got it actually failing on
main), and fixed the issue with the integer columns to make them int dtypes.Testing
pytest --runslow)