batch error logs#484
Merged
hussain-jafari merged 16 commits intoepic/full_scale_testingfrom Jan 24, 2025
Merged
Conversation
…m/ihmeuw/pseudopeople into hjafari/MIC-5503_batch_error_logs
hussain-jafari
requested review from
albrja,
patricktnast,
rmudambi and
stevebachmeier
as code owners
zmbc
reviewed
Jan 24, 2025
| assert not original_data.index.difference(noised_data.index).empty | ||
| with check: | ||
| assert noised_data.index.difference(original_data.index).empty | ||
| assert not original_data.index.difference(noised_data.index).empty |
Collaborator
There was a problem hiding this comment.
Should these be in two separate checks?
patricktnast
approved these changes
Jan 24, 2025
| import pandas as pd | ||
| import pytest | ||
| from _pytest.fixtures import FixtureRequest | ||
| from pytest_check import check # type: ignore |
Contributor
There was a problem hiding this comment.
jw why this type errors?
Contributor
Author
There was a problem hiding this comment.
There aren't any stubs for pytest_check
Contributor
There was a problem hiding this comment.
I think you can just ignore that in the project level file and not in this specific file
stevebachmeier
approved these changes
Jan 24, 2025
| def test_release_tests(pytest_args: list[str]) -> None: | ||
| os.chdir(Path(__file__).parent) # need this to access cli options from conftest.py | ||
| base_cmd = ["pytest", "--release", "test_release.py"] | ||
| base_cmd = ["pytest", "--release", "test_release.py", "--check-max-tb=1000"] |
Contributor
There was a problem hiding this comment.
what is this doing?
Contributor
Author
There was a problem hiding this comment.
This flag controls how many failures are shown at once and, oddly enough, defaults to 1.
rmudambi
approved these changes
Jan 24, 2025
| ( | ||
| check_original.reset_index()[unnoised_id_cols] | ||
| == check_noised.reset_index()[unnoised_id_cols] | ||
| with check: |
Collaborator
There was a problem hiding this comment.
There's only one assertion, so what's the point of putting this in a check block?
Contributor
Author
There was a problem hiding this comment.
Oh yeah this is actually unnecessary
albrja
approved these changes
Jan 24, 2025
hussain-jafari
added a commit
that referenced
this pull request
Feb 10, 2025
Category: feature JIRA issue: MIC-5503 Add with checks. Testing Added multiple assert statements that would fail using with check and verified that they all appeared in the output logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batch error logs
Description
Add with checks.
Testing
Added multiple assert statements that would fail using with check and verified that they all appeared in the output logs.