Better handle py versions and installation instructions#487
Closed
stevebachmeier wants to merge 72 commits intorelease-candidate/v.orange.rebasedfrom
Closed
Better handle py versions and installation instructions#487stevebachmeier wants to merge 72 commits intorelease-candidate/v.orange.rebasedfrom
stevebachmeier wants to merge 72 commits intorelease-candidate/v.orange.rebasedfrom
Conversation
Refactors pseudopeople to create a class that encapsulates dataset schema, the data to be noised, a randomness stream, and the missingness attribute in one place. - *Category*: Refactor - *JIRA issue*: [MIC-4865](https://jira.ihme.washington.edu/browse/MIC-4865) -creates new class to hold dataset schema, a pandas dataframe, a randomness stream, and a missingness bool dataframe -updates fixtures and tests to reflect changes in the refactor Testing All tests pass
Mic-4865/Refactor/rename dataset Renames Dataset to Dataset Schema and DatasetData to Dataset. - *Category*: Refactor - *JIRA issue*: [MIC-4865](https://jira.ihme.washington.edu/browse/MIC-4865) -renames current dataset class to dataset_schema -renames DatasetData to Dataset -updates docstrings Testing All tests pass
Mic-4568/make-format Adds Makefile to run formatters - *Category*: Feature - *JIRA issue*: [MIC-4568](https://jira.ihme.washington.edu/browse/MIC-4568) -adds Makefile to include the following commands (which can be run from the terminal within your conda environment) for quality of life improvement for development: -`make format` which is running black and isort on the codebase -`make integration` which is running `pytest --runslow tests/` -`make unit` which is running `pytest --runslow tests/unit/ ` Testing Ran make format and saw expected behavior.
Mic-5132/no-any-return Mic-5132/no-any-return - *Category*: Other - *JIRA issue*: [MIC-5132](https://jira.ihme.washington.edu/browse/MIC-5132) -fixes instances of no-any-return issues with mypy
Mic-5155/return-value Fix return-value mypy errors - *Category*: Other - *JIRA issue*: [MIC-XYZ](https://jira.ihme.washington.edu/browse/MIC-5155) -fix return value mypy errors
* Pin numpy below 2.0 * fix noise type test * change float to int * remove arg-types * fix layeredconfigtree * fix state column names * fix token probability * fix expected noise * fix target proportions * fix generator errors * fix user filters * lint * adjust to only float * switch to generic types * fix list and tuples builtin * lint * fix error * add Optional * revert optional * try to validate overrides first instead * make user_filters list instead of None * make overrides Any type * fix newlyt broken tests * fix new errors * remove return * Revert "Merge remote-tracking branch 'origin/main' into mic-5154-arg-type" This reverts commit 2b47eae, reversing changes made to b8ecfdf. * fix merge error * lint --------- Co-authored-by: albrja <albrja@uw.edu>
* fix overrides with property * put property above
* fix mypy attr-defined errors * update build workflow to use upstream dependency branches * add layered config tree as a known third party * don't install layered_config_tree inside the repository
Category: typing JIRA issue: MIC-5376 Typing updates related to LayeredConfigTree errors. Testing All tests pass (including slow tests).
stevebachmeier
requested review from
a team,
albrja,
hussain-jafari,
patricktnast,
pletale,
rmudambi and
zmbc
as code owners
stevebachmeier
commented
Feb 4, 2025
| version: 2 | ||
| sphinx: | ||
| fail_on_warning: true | ||
| configuration: docs/source/conf.py |
Contributor
Author
There was a problem hiding this comment.
required for recent sphinx change
Collaborator
There was a problem hiding this comment.
Yep we did this on vivarium_research recently!
Contributor
There was a problem hiding this comment.
@stevebachmeier You can delete this since you will need to rebase and that would probably make it easier for you
zmbc
reviewed
Feb 4, 2025
README.rst
Outdated
|
|
||
| $ git clone https://github.com/ihmeuw/pseudopeople.git | ||
| $ cd pseudopeople | ||
| $ python setup.py install |
Collaborator
There was a problem hiding this comment.
Is this a recommended way to install these days? I'd probably say pip install git+https://github.com/ihmeuw/pseudopeople.git
Contributor
Author
There was a problem hiding this comment.
I thought that was a weird bit of instructions but didn't know enough to change it.
stevebachmeier
force-pushed
the
sbachmei/mic-5669/better-handle-supported-python-versions
branch
from
031de15 to
7f9d47b
Compare
albrja
approved these changes
Feb 5, 2025
stevebachmeier
force-pushed
the
release-candidate/v.orange.rebased
branch
from
5966299 to
6fe4e45
Compare
stevebachmeier
deleted the
sbachmei/mic-5669/better-handle-supported-python-versions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handle py versions and installation instructions
Description
This does a couple of things:
Testing
pytest --runslow)