set up dask client test fix#502
Merged
hussain-jafari merged 2 commits intoepic/full_scale_testingfrom Mar 31, 2025
Merged
Conversation
hussain-jafari
requested review from
albrja,
patricktnast,
rmudambi and
stevebachmeier
as code owners
zmbc
approved these changes
Mar 31, 2025
Collaborator
zmbc
left a comment
zmbc
left a comment
There was a problem hiding this comment.
Looks good! If it turns out to be annoying in more places to have this Dask client "leaking" between tests, you could more aggressively shut it down after every test, but for now it seems like this is the only place it causes problems.
rmudambi
approved these changes
Mar 31, 2025
hussain-jafari
added a commit
that referenced
this pull request
May 7, 2025
Category: bugfix JIRA issue: hotfix When we run pytest --runslow, there are tests that run dask and set up a client which persists in the next tests. We were making an assumption that there is no dask client in test_set_up_dask_client_default. This PR shuts down a client if one already exists. Add full scale testing epic to nightly builds. Testing Ran pytest --runslow.
hussain-jafari
added a commit
that referenced
this pull request
May 7, 2025
Category: bugfix JIRA issue: hotfix When we run pytest --runslow, there are tests that run dask and set up a client which persists in the next tests. We were making an assumption that there is no dask client in test_set_up_dask_client_default. This PR shuts down a client if one already exists. Add full scale testing epic to nightly builds. Testing Ran pytest --runslow.
hussain-jafari
added a commit
that referenced
this pull request
Jul 24, 2025
Category: bugfix JIRA issue: hotfix When we run pytest --runslow, there are tests that run dask and set up a client which persists in the next tests. We were making an assumption that there is no dask client in test_set_up_dask_client_default. This PR shuts down a client if one already exists. Add full scale testing epic to nightly builds. Testing Ran pytest --runslow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set up dask client test fix
Description
When we run pytest --runslow, there are tests that run dask and set up a client which persists in the next tests. We were making an assumption that there is no dask client in test_set_up_dask_client_default. This PR shuts down a client if one already exists.
Testing
Ran pytest --runslow.