Open
Conversation
zmbc
changed the title
hussain-jafari
approved these changes
Apr 11, 2025
aflaxman
approved these changes
Apr 11, 2025
Collaborator
Author
|
Just a doc change, so I don't need to release, right? @rmudambi |
Collaborator
Can you make this change to our release branch? It would simplify things, since we wouldn't need to rebase the branch again, unless this absolutely must be updated in the docs now. |
Collaborator
Author
|
We discussed this while you were out and thought that it was safe to do this, since it wouldn't conflict with anything. But I can also switch it to be on the release branch if you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document limitations of phonetic noise
Description
Testing
None