Open
Conversation
patricktnast
requested review from
albrja,
hussain-jafari,
rmudambi and
stevebachmeier
as code owners
rmudambi
reviewed
Feb 13, 2026
| ) | ||
|
|
||
| def get_results(self) -> list[tuple[pd.DataFrame, dict[str, pd.DataFrame]]]: | ||
| def get_results(self) -> Iterator[tuple[pd.DataFrame, dict[str, pd.DataFrame]]]: |
Contributor
There was a problem hiding this comment.
Shouldn't this be a Generator not an Iterator?
Contributor
Author
There was a problem hiding this comment.
Iterator is more general, and the caller(s) don't rely on any specific features of a generator (e.g. .send(); we just iterate over the tuples. so I think Iterator does make the most sense here
albrja
approved these changes
Feb 17, 2026
hussain-jafari
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Summary, imperative, start upper case, don't end with a period
Description
Changes and notes
Testing