-
Notifications
You must be signed in to change notification settings - Fork 0
Albrja/mic 6764/treatment update #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ebce0ce
Merge disease states and add todos
albrja 38fbb1e
Add method to determine treatment duration
albrja fe93f84
Round treatment effect and wannign effect duration
albrja 9674a43
Pin pandas below 3.0
albrja b580f13
Modify dwell time pipelines
albrja b3726a4
Update relative risk interpolator and utility function to use dwell t…
albrja a8a5e51
Add observer and update config for runs
albrja 13c7ea7
Revert config changes
albrja 1204386
Address pr comments
albrja 08f07e5
Update config for brazil run
albrja f0b3369
Revert config"
albrja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you just set everyone who didn't get treated to have a treatment duration of 0 instead of np.nan, you wouldn't need any mapping at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that in the interactive sim it might be confusing if someone has 0 months of treatment duration but they have never tested positive or ultimately had the chance to be treated. Maybe you wouldn't find that confusing? I do not feel strongly.