-
Notifications
You must be signed in to change notification settings - Fork 0
Sbachmei/mic 6736/vivarium 4 interventions #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevebachmeier
wants to merge
5
commits into
epic/update-to-vivarium-4-vph-5
Choose a base branch
from
sbachmei/mic-6736/vivarium-4-interventions
base: epic/update-to-vivarium-4-vph-5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−117
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
696e039
Round 1: base model with causes and observers
stevebachmeier b5bc3a1
add MaternalInterventions, MaternalInterventionsObserver, and BirthOb…
stevebachmeier 65a8d81
comment out unused components
stevebachmeier fbde060
put model spec back
stevebachmeier 874d58e
stop explicitly requiring the columns used for filtering in observati…
stevebachmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 27 additions & 24 deletions
51
src/vivarium_gates_nutrition_optimization/components/morbidity.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,30 @@ | ||
| from vivarium_public_health.disease import DiseaseModel, SusceptibleState | ||
| # from vivarium_public_health.disease import DiseaseModel, SusceptibleState | ||
|
|
||
| from vivarium_gates_nutrition_optimization.components.disease import ( | ||
| ParturitionExclusionState, | ||
| ) | ||
| # from vivarium_gates_nutrition_optimization.components.disease import ( | ||
| # ParturitionExclusionState, | ||
| # ) | ||
|
|
||
| # NOTE: I have not updated this component to work with the new lookup table | ||
| # configuration work so this component is not used in the model spec because | ||
| # it is currently broken. This component was an exploratory component and may | ||
| # be revisited in the future - albrja | ||
| # NOTE: This has also not been updated to work with the vivarium v4.0 / vph v5.0. | ||
| # Commenting it out. - sbachmei | ||
|
|
||
| def BackgroundMorbidity(): | ||
| # NOTE: I have not updated this component to work with the new lookup table | ||
| # configuration work so this component is not used in the model spec because | ||
| # it is currently broken. This component was an exploratory component and may | ||
| # be revisited in the future - albrja | ||
| cause = "other_causes" | ||
| susceptible = SusceptibleState(cause) | ||
| with_condition = ParturitionExclusionState( | ||
| cause, | ||
| allow_self_transition=True, | ||
| get_data_functions={ | ||
| "prevalence": lambda *_: 1.0, | ||
| "excess_mortality_rate": lambda *_: 0.0, | ||
| }, | ||
| ) | ||
| return DiseaseModel( | ||
| cause, | ||
| states=[susceptible, with_condition], | ||
| get_data_functions={"cause_specific_mortality_rate": lambda *_: 0.0}, | ||
| ) | ||
|
|
||
| # def BackgroundMorbidity(): | ||
| # cause = "other_causes" | ||
| # susceptible = SusceptibleState(cause) | ||
| # with_condition = ParturitionExclusionState( | ||
| # cause, | ||
| # allow_self_transition=True, | ||
| # get_data_functions={ | ||
| # "prevalence": lambda *_: 1.0, | ||
| # "excess_mortality_rate": lambda *_: 0.0, | ||
| # }, | ||
| # ) | ||
| # return DiseaseModel( | ||
| # cause, | ||
| # states=[susceptible, with_condition], | ||
| # get_data_functions={"cause_specific_mortality_rate": lambda *_: 0.0}, | ||
| # ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,13 +134,6 @@ def sample_full_term_durations(self, full_term_pop: pd.Index) -> pd.DataFrame: | |
| ) | ||
| return child_status | ||
|
|
||
| def get_dwell_time_pipeline(self, builder: Builder) -> Pipeline: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is no longer a method in the super class (DiseaseState) and we don't seem to need it anywhere? |
||
| return builder.value.register_value_producer( | ||
| f"{self.state_id}.dwell_time", | ||
| source=lambda index: self.population_view.get(index)["pregnancy_duration"], | ||
| requires_columns=["age", "sex", "pregnancy_outcome"], | ||
| ) | ||
|
|
||
| def get_initial_event_times(self, pop_data: SimulantData) -> pd.DataFrame: | ||
| """Overwrite the BaseDiseaseState method""" | ||
| return pd.DataFrame( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already had a similar comment in the morbidity.py but I figured we should either delete or at least comment out out-of-date things so that it doesn't keep tricking us into "updating" it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And this class only seems to be used by morbidity component)