Add yaml configuration/ parsing of Extraction Configuration#12
Merged
patricktnast merged 55 commits intomainfrom Jan 16, 2026
Merged
Add yaml configuration/ parsing of Extraction Configuration#12patricktnast merged 55 commits intomainfrom
patricktnast merged 55 commits intomainfrom
Conversation
…h are defined in a particular way.
tests/test_extraction.py
Outdated
| assert pattern1.extract_percall is True | ||
| assert pattern1.extract_ncalls is True | ||
|
|
||
| # Pattern with custom template |
Contributor
There was a problem hiding this comment.
mybe check name the following two patterns as well?
| def test_from_yaml_mixed_patterns(self): | ||
| """Test parsing YAML with various pattern configurations and templates.""" | ||
| yaml_content = """ | ||
| patterns: |
Contributor
There was a problem hiding this comment.
I don't know the overlap w/ defaults, but is this testing both a full replacement as well as a partial replacement?
stevebachmeier
approved these changes
Jan 12, 2026
albrja
approved these changes
Jan 12, 2026
rmudambi
approved these changes
Jan 13, 2026
…/ihmeuw/vivarium_profiling into pnast/refactor/mic-6373-plotting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add yaml configuration/ parsing of Extraction Configuration
Description
feature
Changes and notes
We made the 'extraction configuration' but didn't make it actually configurable by the user. this proposed a yaml syntax to be able to do that.
Verification and Testing