Skip to content

fix(test): make documentation contracts semantic - #260

Merged
ihor-sokoliuk merged 4 commits into
mainfrom
codex/test/semantic-doc-contracts
Aug 25, 2026
Merged

fix(test): make documentation contracts semantic#260
ihor-sokoliuk merged 4 commits into
mainfrom
codex/test/semantic-doc-contracts

Conversation

@ihor-sokoliuk

Copy link
Copy Markdown
Owner

Summary

  • validate all release version surfaces against exact SemVer and package.json instead of a frozen release number
  • derive documented Node support from package metadata and validate GitHub Actions by immutable pin/comment semantics
  • split Node, workflow pin, and Dependabot documentation contracts while retaining provenance checks

Verification

  • npm run lint
  • npm run build
  • npm run test:coverage (773/773, 96.04% lines)
  • npm run test:e2e (35/35)
  • npm run verify:packed-consumer
  • focused version tests (4/4)
  • focused documentation tests (23/23)

Copilot AI lite review requested due to automatic review settings August 25, 2026 14:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ihor-sokoliuk
ihor-sokoliuk requested a lite review from Copilot August 25, 2026 14:12
@codacy-production

codacy-production Bot commented Aug 25, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ihor-sokoliuk

Copy link
Copy Markdown
Owner Author

Addressed in 8c24e7d — verified valid. The exact SemVer contract now uses bounded structural parsing for core, prerelease, and build identifiers, eliminating the non-literal RegExp constructor while retaining malformed-version and drift rejection coverage. No review findings were left unchanged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ihor-sokoliuk

Copy link
Copy Markdown
Owner Author

Addressed in 22138d0 — verified valid. The structural SemVer validator is now split into small helpers for identifier, build metadata, core, and prerelease validation, retaining the same exact acceptance and rejection fixtures while reducing per-function complexity. No review findings were left unchanged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are test-only, and the new SemVer and workflow-pin logic was verified against the repository's actual manifests, README, CI matrix, and workflow files, leaving only one optional latent-robustness note.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread __tests__/unit/documentation.test.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ihor-sokoliuk
ihor-sokoliuk merged commit 2fc0487 into main Aug 25, 2026
6 checks passed
@ihor-sokoliuk
ihor-sokoliuk deleted the codex/test/semantic-doc-contracts branch August 25, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants