Update search_metadata.py ETC (sync from upstream: 9 commits / 64 files changed)#365
Update search_metadata.py ETC (sync from upstream: 9 commits / 64 files changed)#365holta merged 9 commits intoiiab:masterfrom
Conversation
Fix TypeError when metadata provider returns None
Kobo: include PriorityTimestamp in PUT /state response
In series_list(), the SQLite query correctly orders results by Series.sort, but a subsequent Python sorted() call (needed to re-order after appending the "None" category entry) was using Series.name as the sort key instead of Series.sort. This caused series titles with leading articles (A, An, The) to sort strictly alphabetically by the article rather than by the meaningful word, e.g. "A Collins-Burke Mystery" appeared under "A" instead of "C". Fix by using Series.sort (with a fallback to Series.name if sort is NULL) as the key in the Python re-sort, consistent with the intent of the existing DB query. Fixes #3583
…y-name-instead-of-sort-field'
holta
changed the title
|
@Akatama @chapmanjacobd will a restructuring of this CI workflow plausibly/hopefully help avoid "false negatives" ? (FWIW https://github.com/iiab/calibre-web/actions/runs/22796429132/job/66141089832?pr=365 below again appears to show an ongoing pattern, with PR's containing upstream commits somehow not being tested in a useful way :-) 
|
|
(I'll go ahead and merge this experimentally — so we have another data point to try to confirm — allowing us to hopefully clean up this problematic CI workflow soon?) |
Confirmed! After merging this PR into our master branch: 
cc: @Akatama @chapmanjacobd @deldesir let's work on this in coming days (this week!) if you have time to try to help rework this CI workflow, so that it properly avoids "False Negatives" (: 🙏 |
|
It must be something close to here: https://github.com/iiab/iiab/blob/c87f0add3d0c562ce7b764a87e3fdda1fce5e198/roles/calibre-web/tasks/install.yml#L92 |
Looks like you found the culprit... I think! (: |
How about we ignore var
Is this kind of approach or similar... reasonable? |
|
Makes sense to me! Just use |
6 participants
Fix TypeError when metadata provider returns None