Restore GAMSModel.__init__(…, name_=…) argument #587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of this argument in #581 broke message_ix and message-ix-models
mainbranches, as evidenced by scheduled CI, for instance here:Related:
ixmp.model.get_model()andScenario.solve(), must be usable with any subclass of ixmp.model.base.Model. If such subclasses are created in the future (see for instance Migrating away from GAMS message_ix#879 (comment)) they may have different arguments than GAMSModel.Also:
.base.Model.initialize_items(). Changes to this method in Enable strict mypy settings #581 resulted in spurious messages like:How to review
message_ixtest suite with the code on this branch.PR checklist
Add, expand, or update documentation.Bugfix.