-
Notifications
You must be signed in to change notification settings - Fork 115
Enhance functionality of IXMP4Backend
#601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97f6c44 to
74154b8
Compare
74154b8 to
642d21e
Compare
10382f5 to
cad9d8c
Compare
Codecov Report❌ Patch coverage is Please upload reports for the commit 00d2867 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
- Coverage 98.5% 98.2% -0.3%
=======================================
Files 51 51
Lines 6345 6557 +212
=======================================
+ Hits 6251 6444 +193
- Misses 94 113 +19
🚀 New features to boost your workflow:
|
da72319 to
95cf3ff
Compare
* Enable writing timeseries data to csv * Clarify usage of timeslice-functions * Clarify usage of geo-functions
* Implement caching behaviour correctly * Handle meta= argument to timeseries functions * Handle from_year argument to clear_solution() * Reraise dedicated IXMP4 errors as expected Exceptions * Fix various small things to satisfy the test suite
* Remove outdated 'jdbc_only' marker * Use 'jdbc' and 'ixmp4' markers consistently * Add 'ixmp4_never' and 'ixmp4_not_yet' markers * Enable numerous tests for ixmp4 * Clarify remaining markers limiting ixmp4 tests * Reduce re-usage of fixtures
- Organize changes according to public API methods. - Use higher-level heading. - Link to existing descriptions in doc/data-model.rst instead of repeating these. - Change reST links to non-public ixmp_source code to comments. - Move implementation details that do not change user API to IXMP4Backend method docstrings. - Use :attr:/:meth: reST roles instead of :func: where needed.
|
Here is the run in which all checks pass. |
95f8d72 to
00d2867
Compare
|
Thanks for picking this up and pushing it over the finish line :) |
It turns out I/we should have done this before merging, as today workflows in message-ix, message-ix-models, and message_data are failing with the updated I think this happens because ixmp.testing is used as a pytest plugin in those test suites, so I'll open a PR to fix. |
This PR expands the functionality of
IXMP4Backend, bringing it closer to full parity withJDBCBackend. It does so by:Setting up Postgres on GitHub Actions
The GHA runners only provide Postgres installations on Windows and Linux, but not on Macos. Thus, I'm trying to use this third-party action, which works on all OSs and is actively maintained.
How to review
#NOTE,#TODOand#FIXMEmarks in the diff and respond if necessary.@pytest.mark.ixmp4,@pytest.mark.ixmp4_not_yet, and@pytest.mark.ixmp4_neverto see if the usage/explanations are clear.TBD:
PR checklist
; coverage checks both ✅(see below)