Skip to content

Improve aviation emissions postprocessing #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve aviation emissions postprocessing #333

wants to merge 6 commits into from

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Apr 10, 2025 •
edited
Loading

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

khaeru added 2 commits April 10, 2025 12:20
@khaeru
Reformat data/transport/emi-intensity.csv
b530a24 
- Group and sort by 'emission' instead of by source.
- Record differing sources in line-end comments.
- Add commented lines for missing species.
@khaeru
Add estimated transport emi-intensity.csv values
1a9bc6f
@khaeru khaeru requested a review from r-aneeque as a code owner April 10, 2025 11:22
@khaeru khaeru self-assigned this Apr 10, 2025
@khaeru khaeru added enh New features or functionality report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model p:SSP-2024 2024 SSP updates and ScenarioMIP labels Apr 10, 2025
@khaeru khaeru force-pushed the project/ssp/transport/2025-04-10 branch from cc15e9c to f0d99c9 Compare April 10, 2025 11:31
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (818623b) to head (b739d06).

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #333     +/-   ##
=======================================
- Coverage   78.6%   77.7%   -0.9%     
=======================================
  Files        215     215             
  Lines      17219   17220      +1     
=======================================
- Hits       13536   13389    -147     
- Misses      3683    3831    +148
Files with missing lines Coverage Δ
message_ix_models/project/ssp/transport.py 95.8% <100.0%> (-0.1%) ⬇️
...sage_ix_models/tests/project/ssp/test_transport.py 97.9% <100.0%> (+<0.1%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

khaeru added 2 commits April 10, 2025 14:22
@khaeru
Separate 3 kinds of annotations in emission.yaml
010d01b
@khaeru
Improve .ssp.transport.e_UNIT()
0ff001a 
- Distinguish species in labels and unit expressions.
- Use annotations from emission.yaml.
- Align with input data.
@khaeru khaeru force-pushed the project/ssp/transport/2025-04-10 branch from f0d99c9 to de1160b Compare April 10, 2025 12:29
@khaeru khaeru force-pushed the project/ssp/transport/2025-04-10 branch from de1160b to b739d06 Compare April 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-aneeque r-aneeque Awaiting requested review from r-aneeque r-aneeque is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@khaeru khaeru

Labels
enh New features or functionality p:SSP-2024 2024 SSP updates and ScenarioMIP report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand .ssp.transport to include the e=CO₂ species
1 participant
@khaeru