Skip to content

Add T into the BMT workflows and update MACRO for BMT - #486

Open
yiyi1991 wants to merge 47 commits into
mainfrom
bmt_dev_ngfs_c1
Open

Add T into the BMT workflows and update MACRO for BMT#486
yiyi1991 wants to merge 47 commits into
mainfrom
bmt_dev_ngfs_c1

Conversation

@yiyi1991

@yiyi1991 yiyi1991 commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

This is a PR to include

  • transport build,
  • transport report,
  • add MACRO,
  • full report chain (M+T+legacy report including B),
  • and other series updates for project implementation.

See the tracker of bmt development (issue #483, milestone for NGFS C1 submission).

This PR branch is based on…

How to review

  • Read the diff and note that the CI checks all pass.
  • The documentation makes sense.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru

khaeru commented Apr 26, 2026

Copy link
Copy Markdown
Member

As discussed in Slack, the conflicts here are due to changes I made to #433 in getting it ready to merge. So I will take care of the rebase here to both (a) address the conflicts and (b) bring the branch up to date with main. Will comment once this is pushed with any extra explanation (beyond the docs/whatsnew).

@khaeru khaeru added this to the 2026-05 milestone Apr 26, 2026
@khaeru khaeru mentioned this pull request Apr 26, 2026
@khaeru

khaeru commented Apr 26, 2026

Copy link
Copy Markdown
Member

So I will take care of the rebase here to both (a) address the conflicts and (b) bring the branch up to date with main. Will comment once this is pushed with any extra explanation (beyond the docs/whatsnew).

This is now done; please see main...bmt_dev_ngfs_c1-check

The branch goes from:

  • 62 commits → 15.
  • 29 files changed → 11.
  • +2046/-76 lines → +379/-99.

If that looks good (i.e. nothing is missing), I will force-push the branch for this PR to overwrite. Please let me know if I can do that.

@khaeru

khaeru commented Apr 27, 2026

Copy link
Copy Markdown
Member

I will force-push the branch for this PR to overwrite.

Now done 👍🏾

@yiyi1991

Copy link
Copy Markdown
Contributor Author

I will force-push the branch for this PR to overwrite.

Now done 👍🏾

Thanks. I will start adding tests and doc.

@khaeru

khaeru commented May 8, 2026

Copy link
Copy Markdown
Member

Now rebased on the branch for #497.

  • The final commit on that branch is (and always will be; I'll reorder to keep it so) "Add Transport improvements for 2026-W16 #497 to doc/whatsnew".
  • Thus the commits unique to this branch are the ones following, starting with "Partly revert d86843e".

yiyi1991 and others added 28 commits August 17, 2026 18:05
Avoid oversupply of these commodities.
- Avoid needless use of monkeypatch.
- Construct a temporary file in a fixture.
- Type hint test functions.
- Remove assertion about existence/type of packaged file.
- Use assign() to compute derived values.
- Remove _ prefix on function name.
- Accept Path for `output_path`, remove Path→str→Path conversion.
- Type hint and simplify test functions.
Avoid defining a new workflow step with the same name.
- Use existing .buildings.Config.code_dir.
- Add assertions for existence of the directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants