Add T into the BMT workflows and update MACRO for BMT - #486
Conversation
cb2f36a to
acb3bf7
Compare
|
As discussed in Slack, the conflicts here are due to changes I made to #433 in getting it ready to merge. So I will take care of the rebase here to both (a) address the conflicts and (b) bring the branch up to date with |
This is now done; please see main...bmt_dev_ngfs_c1-check The branch goes from:
If that looks good (i.e. nothing is missing), I will force-push the branch for this PR to overwrite. Please let me know if I can do that. |
Now done 👍🏾 |
Thanks. I will start adding tests and doc. |
|
Now rebased on the branch for #497.
|
Avoid oversupply of these commodities.
- Apply code style.
- Avoid needless use of monkeypatch. - Construct a temporary file in a fixture. - Type hint test functions. - Remove assertion about existence/type of packaged file.
- Use assign() to compute derived values. - Remove _ prefix on function name. - Accept Path for `output_path`, remove Path→str→Path conversion. - Type hint and simplify test functions.
Avoid defining a new workflow step with the same name.
- Use existing .buildings.Config.code_dir. - Add assertions for existence of the directory.
64a9980 to
115107c
Compare
This is a PR to include
See the tracker of bmt development (issue #483, milestone for NGFS C1 submission).
This PR branch is based on…
was merged in Transport improvements for 2026-W04 #471.transport/2026-w04was merged in Transport improvements for 2026-W16 #497.transport/2026-w16main.How to review
PR checklist