Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Apr 2, 2021

This PR continues from the issue discovered at #452 (comment):

The Windows tests appear to all pass, but the step is failing:

XFAIL message_ix/tests/test_core.py::test_add_horizon[args7-kwargs7-None]
XFAIL message_ix/tests/test_core.py::test_add_horizon[args8-kwargs8-None]
==== 113 passed, 2 deselected, 5 xfailed, 4 warnings in 444.20s (0:07:24) =====
Error: Process completed with exit code 1.

Steps taken:

How to review

No review; CI changes only.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A; CI changes only.
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Apr 2, 2021
@khaeru khaeru self-assigned this Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #453 (b3f4580) into master (4930f90) will not change coverage.
The diff coverage is n/a.

❗ Current head b3f4580 differs from pull request most recent head d76d76c. Consider uploading reports for the commit d76d76c to get more accurate results

@@          Coverage Diff           @@
##           master    #453   +/-   ##
======================================
  Coverage    93.3%   93.3%           
======================================
  Files          37      37           
  Lines        2800    2800           
======================================
  Hits         2613    2613           
  Misses        187     187           

@khaeru khaeru force-pushed the windows-ci branch 2 times, most recently from eee0eef to ee5616e Compare April 3, 2021 13:53
@khaeru khaeru changed the title Debug/fix Windows CI failures Work around Windows CI failures Apr 5, 2021
@khaeru khaeru merged commit 47c34d4 into master Apr 5, 2021
@khaeru khaeru deleted the windows-ci branch April 5, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant