Skip to content

Conversation

@gidden
Copy link
Member

@gidden gidden commented Apr 6, 2022

Required: write a single sentence that describes the changes made by this PR.

This PR raises an exception at the start of add_year()

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

Confirm that tests still pass and advise on any issues that arise as a result of non-passage

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@gidden
Copy link
Member Author

gidden commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

@LauWien
Copy link
Contributor

LauWien commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

Hm, possible we can create a new PR where we run black in the whole repository and then rebase this PR once merged? @khaeru what do you think?

@LauWien
Copy link
Contributor

LauWien commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

I just see your branch is out of date with master, I guess a rebase will do the trick.

@gidden
Copy link
Member Author

gidden commented Apr 6, 2022

ah hah - let me rebase and cherry-pick

@glatterf42
Copy link
Member

Closing this since always raising this exception does not seem the correct way forward to me. And if we do decide to take that route later on, we can always revisit this PR and copy the lines from here.

@glatterf42 glatterf42 closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants