Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Jan 21, 2025

#909 introduced invalid GitHub Actions syntax 🤦🏾‍♂️. This PR:

  • Fixes the error.
  • Adds pre-commit configuration to check that the workflow files (a) are valid YAML and (b) conform to GitHub's published schemas.

How to review

Read the diff.

PR checklist

  • Continuous integration checks all ✅ As with Run "pytest" GHA workflow on pull_request_target #909, the required checks from the "pytest" workflow will not run; this time because of the syntax error.
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, CI changes only
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Jan 21, 2025
@khaeru khaeru self-assigned this Jan 21, 2025
@khaeru khaeru merged commit e0f2e02 into main Jan 21, 2025
4 of 5 checks passed
@khaeru khaeru deleted the ci/pull-request-target-2 branch January 21, 2025 12:41
khaeru added a commit that referenced this pull request Jan 21, 2025
- Drop old content:
  - Commented GAMS_VERSION.
  - Workaround for pyam-iamc exclusion of Python 3.13.
- Narrow workaround for ts-graphviz/setup-graphviz#630.
- Adjust 'tutorials' jobs parallel to #909, #910.
- Simplify installation of reticulate.
  - Drop use of "remotes"; call install.packages() directly.
khaeru added a commit that referenced this pull request Jan 21, 2025
- Drop old content:
  - Commented GAMS_VERSION.
  - Workaround for pyam-iamc exclusion of Python 3.13.
- Narrow workaround for ts-graphviz/setup-graphviz#630.
- Adjust 'tutorials' jobs parallel to #909, #910.
- Simplify installation of reticulate.
  - Drop use of "remotes"; call install.packages() directly.
ywpratama pushed a commit to ywpratama/message_ix that referenced this pull request Jun 11, 2025
- Drop old content:
  - Commented GAMS_VERSION.
  - Workaround for pyam-iamc exclusion of Python 3.13.
- Narrow workaround for ts-graphviz/setup-graphviz#630.
- Adjust 'tutorials' jobs parallel to iiasa#909, iiasa#910.
- Simplify installation of reticulate.
  - Drop use of "remotes"; call install.packages() directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant