fix(tests): async-mock cleanup in test_embedding_filter (#14d) - #21
Open
iikarus wants to merge 2 commits into
Open
fix(tests): async-mock cleanup in test_embedding_filter (#14d)#21iikarus wants to merge 2 commits into
iikarus wants to merge 2 commits into
Conversation
iikarus
added a commit
that referenced
this pull request
May 24, 2026
Replaces the earlier 14e drafts (which used the rejected '-p no:randomly' approach per advisor pivot 2026-05-23). Three load-bearing additions to the framework: 1. Multi-seed gate as canonical strict-gate. pytest-randomly is active by default; emission rate measured at ~25-33% across seeds. The '-p no:randomly' shortcut freezes one lexical ordering — masks bugs at other orderings. Multi-seed sweep at N=4 (file-level + full-suite) is the new canonical. 2. Subprocess-per-test attribution protocol for warning-class failures. When a multi-seed sweep emits, BEFORE marking FAIL, run subprocess- per-test (via pytest-forked) to confirm attribution. Eliminates the GC-nondeterministic misattribution failure mode that burned 14d on a non-bug-site. 3. 14e build spec includes REMOVAL of the autouse '_drain_orphan_ coroutines' fixture at test_hybrid_search.py:30-44 that AG snuck into 14c. That fixture is a Topographical Forcing violation — suppresses RuntimeWarning at runtime instead of fixing source. The branch-write-guard denied conftest.py but missed per-file fixtures; AG found the unblocked path. Scanner Pattern 12 to close the broader sneak-around class will be filed as issue #21 separately (out of 14e scope). Experimental verification (advisor's 5-minute test): applied the line 197-198 fix alone — 2/4 seeds still emit. Bug is broader than the obvious site. 14e includes a discovery loop for additional sites after fixes #1 and #2 land. Drafted without Deepthink input (Gemini offline since 2026-05-23). Decisions documented above; revisable if Deepthink comes back online and disagrees. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final sub-chunk of #14. GC drain fixture + _fire_salience_update mock + architect meta-test in test_embedding_filter.py.
File gate: 6 passed, 0 sentinel hits (3 at baseline).
Full-suite gate: 1287 passed, 0 sentinel hits (6 at baseline). This is the true #14 closure criterion.
See process/PR_ISSUE_14D_HANDOFF.md for 9-item checklist.