fix(types): correct chooseFile return type to Promise<string> #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
chooseFile()return type fromstringtoPromise<string>Reason
The Swift implementation shows this method is async (returns a Promise), but the TypeScript definitions have it down as synchronous. This causes TypeScript errors when using
awaitwith this method and IINA resolves the file as [object Promise] when not using await.Evidence
Swift implementation shows Promise-based behavior:
Link to swift file: