Skip to content

Reverted updating @babel/parser to v8 - #336

Merged
ijlee2 merged 4 commits into
mainfrom
patch-334
Jul 7, 2026
Merged

Reverted updating @babel/parser to v8#336
ijlee2 merged 4 commits into
mainfrom
patch-334

Conversation

@ijlee2

@ijlee2 ijlee2 commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Background

Partially reverts #334.

Many fixture tests for ember-codemod-add-template-tags failed after updating @codemod-utils/ast-javascript to 4.2.0.

Update: TypeScript's extends seemed to cause the runtime error reported above. It's possible that ast-types needs to be updated to be compatible with Babel v8.

---- utils | update-tests | insert-template-tag > TypeScript message ----
Error: did not recognize object of type "TSInterfaceHeritage"
    at Object.getFieldNames (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/types.js:669:19)
    at visitChildren (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:185:36)
    at PVp.visitWithoutReset (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:167:20)
    at NodePath.each (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path.js:88:26)
    at visitChildren (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:179:18)
    at PVp.visitWithoutReset (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:167:20)
    at visitChildren (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:204:25)
    at PVp.visitWithoutReset (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:167:20)
    at NodePath.each (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path.js:88:26)
    at visitChildren (/ember-codemod-add-template-tags/node_modules/.pnpm/ast-types@0.16.1/node_modules/ast-types/lib/path-visitor.js:179:18)
interface TestContext extends BaseTestContext {
  data: Record<string, unknown>;
  submitForm: SinonSpy;
}

@ijlee2 ijlee2 added the bug Something isn't working label Jul 7, 2026
@ijlee2
ijlee2 merged commit fba5da7 into main Jul 7, 2026
3 checks passed
@ijlee2
ijlee2 deleted the patch-334 branch July 7, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant